fix(tui): show xhigh reasoning warning for gpt-5.2 #7910
Conversation
|
@codex r |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
etraut-openai
left a comment
etraut-openai
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I don't think tests are needed for these changes. They're unlikely to regress. Other than that, it looks good.
codex-rs/tui/src/chatwidget/tests.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn model_reasoning_selection_popup_extra_high_warning_gpt52_snapshot() { |
There was a problem hiding this comment.
No test is needed here. Please delete.
| assert_snapshot!("model_reasoning_selection_popup_extra_high_warning", popup); | ||
| } | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
No test is needed here. Please delete.
- Extend reasoning-effort popup warning eligibility to gpt-5.2* models for the Extra high (xhigh) option. - Add snapshot tests and accept new snapshots for the gpt-5.2 extra-high warning in codex-tui and codex-tui2.
voctory
force-pushed
the
warn-xhigh-usage-5-2
branch
from
f6052fa to
bcbb72d
Compare
|
@codex r |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Thanks for the feedback @etraut-openai, I've removed those tests |
2 participants
Notes
Revisions
Testing
just fix,cargo test -p codex-tui, andcargo test -p codex-tui2Before:
After (consistent with GPT 5.1 Codex Max):
