Module not found inside getNetworkServiceNames

[saphitv]

Versions

oracledb: 6.7.0
node: 21.4.0
platform: win32
arch: x64

Description

I'm encountering issues launching my Next.js (15.0.3) project. It crashes upon startup.
I tried to change the require from an absolute path to ./thin/sqlnet/paramParser.js and it works.
I am using oracledb in thin mode.
I was wondering if i was doing something wrong or what the solution might be.

If the information is not enough, I remain at your disposal.

Stacktrace

 ⨯ ./node_modules/oracledb/lib/oracledb.js:668:47
Module not found: Can't resolve 'thin/sqlnet/paramParser.js'
  666 | //-----------------------------------------------------------------------------
  667 | async function getNetworkServiceNames(configDir) {
> 668 |   const { NLParamParser, tnsnamesFilePath } = require('thin/sqlnet/paramParser.js');
      |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  669 |   const nlParamParser =  new NLParamParser;
  670 |   const filePath = tnsnamesFilePath(configDir);
  671 |   const aliasht = await nlParamParser.initializeNlpa(filePath);

[sharadraju]

@saphitv Thanks for reporting this.
I believe your fix is one of the right solutions. We will internally check in the meantime and get back to you.

Is it happening only on startup of your Next.js project?

[sharadraju]

Ok, I am able to replicate this issue internally with a sample Next.js app.
@saphitv
We will add the fix that you had mentioned in the next patch release:

diff --git a/lib/oracledb.js b/lib/oracledb.js
index ea3b41528..b71690b82 100644
--- a/lib/oracledb.js
+++ b/lib/oracledb.js
@@ -665,7 +665,7 @@ async function createPool(options) {
 // If a tnsnames.ora file does not exist, then an exception is raised
 //-----------------------------------------------------------------------------
 async function getNetworkServiceNames(configDir) {
-  const { NLParamParser, tnsnamesFilePath } = require('thin/sqlnet/paramParser.js');
+  const { NLParamParser, tnsnamesFilePath } = require('./thin/sqlnet/paramParser.js');
   const nlParamParser =  new NLParamParser;
   const filePath = tnsnamesFilePath(configDir);
   const aliasht = await nlParamParser.initializeNlpa(filePath);

As a temporary workaround, you can add also add the following change in your next.config.(m)js file:

/** @type {import('next').NextConfig} */
const nextConfig = {
  webpack: config => {
    /**
     * These packages need to be added as external, else Oracle DB will try to load them due to a
     * Webpack bug.
     *
     * See these two issues for more information:
     * - https://github.com/oracle/node-oracledb/issues/1688
     * - https://github.com/oracle/node-oracledb/issues/1691
     **/
    config.externals.push(
      ...[
        "@azure/app-configuration",
        "@azure/identity",
        "@azure/keyvault-secrets",
        "oci-common",
        "oci-objectstorage",
        "oci-secrets",
      ],
    );
	config.resolve.preferRelative = true;

    return config;
  },};

export default nextConfig;

The config.resolve.preferRelative = true; is used to tell Next.js to search relative paths as well.

[saphitv]

perfefct, thanks

[acid24]

Hi @sharadraju,

I was encountering the same error described in this issue, but config.resolve.preferRelative = true; does not work in a NextJS 15.0.3 application that uses NextAuth 5, causing more errors. Is there an estimate about when 6.7.1 will be released? Or is there another workaround? Would it be possible to release a version with only this fix, since from what I understand it's only a one line change?

Thank you in advance.

[cjbj]

@acid24 you could create the change as a patch file and install it with a postinstall script, see #1391 (comment)

[acid24]

Thanks @cjbj I'll give that a try

[sharadraju]

This is now fixed in the 6.7.1 release