QueryStream broken in Node 4 and 6 (2.1)

[wubzz]

1. What is your Node.js version? Is it 64-bit or 32-bit? Run version.js from
   64-bit v4.8.7 & v6.13.0

2. What is your node-oracledb version?
   Latest

3. What error(s) you are seeing?

Uncaught TypeError: self.destroy is not a function

After this commit our CI tests over at knex started breaking with the above error message. After some digging I realized that .destroy was added to ReadableStream in node 8+, which means the current version of the lib does not work for Node < 8.

The README states

Use node-oracledb to connect Node.js 4, 6, 8 and 9 to Oracle Database.

[cjbj]

Hmm.

[cjbj]

@dmcghan and @anthony-tuininga have a fix:

diff --git a/lib/querystream.js b/lib/querystream.js
index f1a13a4b..bd412e9a 100644
--- a/lib/querystream.js
+++ b/lib/querystream.js
@@ -69,7 +69,7 @@ function QueryStream(resultSet, oracledb) {
     // Using setImmediate to ensure that end event handlers are processed
     // before the destroy logic is invoked.
     setImmediate(function() {
-      self.destroy();
+      self._destroy(null, function() {});
     });
   });
 }

When the world (i.e. the Windows people in the team) wake up and we can get Windows binaries built, we'll push a v2.1.1.

After Spring holiday is over and everyone is back at work, we'll have a postmortem to work out how this got missed!

[cjbj]

I've released 2.1.1. Give it a whirl!

[elhigu]

It works! :) 🎉

[cjbj]

@elhigu yay!