Skip to content

Conversation

@alexhenrie
Copy link
Contributor

I added tests for this, but since I don't have a local Oracle database for testing, I can't be 100% sure that they work.

@cjbj
Copy link

cjbj commented May 14, 2020

@alexhenrie
Copy link
Contributor Author

Don't forget to update https://github.com/oracle/python-cx_Oracle/blob/master/doc/src/release_notes.rst !!

Done.

Copy link
Member

@anthony-tuininga anthony-tuininga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If you can make those few changes I'll merge it.

@cjbj
Copy link

cjbj commented May 15, 2020

I added tests for this, but since I don't have a local Oracle database for testing, I can't be 100% sure that they work.

Creating a DB using Oracle Cloud's free https://www.oracle.com/cloud/free/ tier can be handy for testing.

@alexhenrie
Copy link
Contributor Author

Creating a DB using Oracle Cloud's free https://www.oracle.com/cloud/free/ tier can be handy for testing.

Thanks for the suggestion! I created an Oracle Cloud account today and was able to confirm that the new tests work as they should :-)

@anthony-tuininga anthony-tuininga merged commit 17fd92f into oracle:master May 15, 2020
@anthony-tuininga
Copy link
Member

Thanks, @alexhenrie!

@anthony-tuininga
Copy link
Member

I made a few tweaks after examining it a bit more. Hopefully the changes are clear but if you have questions, yell out!

@alexhenrie
Copy link
Contributor Author

I made a few tweaks after examining it a bit more. Hopefully the changes are clear but if you have questions, yell out!

Looks good to me. Thanks!

@alexhenrie alexhenrie deleted the true branch August 26, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants