Fix #206: Null coalescing operator on Vector make search failed #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens because php_ds_vector_read_dimension makes a REF from the value when type is not BP_VAR_R. So when the type is BP_VAR_IS then we see the first element becomes a reference. You can see this when doing var_dump.
Contributor
Author
|
AppVeyor seems to fail because the SDK that you download in the workflow is outdated and thus not aware of PHP 8.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens because php_ds_vector_read_dimension makes a REF from the value when type is not BP_VAR_R. So when the type is BP_VAR_IS then we see the first element becomes a reference. You can see this when doing var_dump.