Polyfill signatures inconsistent with the extension

[BenMorel]

These interfaces and classes implement ArrayAccess in the extension:

$classes = array_merge(get_declared_interfaces(), get_declared_classes());

foreach ($classes as $class) {
    if (substr($class, 0, 3) === 'Ds\\') {
        if ((new ReflectionClass($class))->implementsInterface(ArrayAccess::class)) {
            echo "$class\n";
        }
    }
}

Ds\Sequence
Ds\Vector
Ds\Deque
Ds\Stack
Ds\Map

However, I can see that the following classes/interfaces implement ArrayAccess in the polyfill:

Ds\Queue
Ds\Stack
Ds\Sequence
Ds\Set
Ds\Map

In short, the following classes implement ArrayAccess in the polyfill but not in the extension (at least, according to reflection):

• Queue
• Set

Is this an issue with the polyfill or the extension?

[BenMorel]

I also started a PR for the PHP docs, that don't mention ArrayAccess at all: php/doc-en#161

Clarification welcome!

[BenMorel]

Actually, I think this is an issue in the extension. The Queue and Set classes do implement ArrayAccess methods, but do not report it:

$classes = array_merge(get_declared_interfaces(), get_declared_classes());

foreach ($classes as $class) {
    if (substr($class, 0, 3) === 'Ds\\') {
        echo str_pad($class, 16, ' ');

        $r = new ReflectionClass($class);

        if ($r->hasMethod('offsetGet')) {
            echo ' offsetGet';
        }

        if ($r->implementsInterface(ArrayAccess::class)) {
            echo ' ArrayAccess';
        }

        echo "\n";
    }
}

Ds\Hashable     
Ds\Collection   
Ds\Sequence      offsetGet ArrayAccess
Ds\Vector        offsetGet ArrayAccess
Ds\Deque         offsetGet ArrayAccess
Ds\Stack         offsetGet ArrayAccess
Ds\Queue         offsetGet
Ds\Map           offsetGet ArrayAccess
Ds\Set           offsetGet
Ds\PriorityQueue
Ds\Pair    

[BenMorel]

Closing in favour of php-ds/ext-ds#163.

[rtheunissen]

👍