Return string from DummyTest::__toString

[WyriHaximus]

As stated in the PHP documentation the __toString has to return a string. Currently the DummyTest::__toString method doesn't comply with this and throws errors like this one in several of my PSR-3 releated packages.

Returning a string from DummyTest::__toString as is expected by the language would solve those errors.

[GrahamCampbell]

Don't move the stub to its own file. This will make phpunit complain about there being no tests in the file.

[WyriHaximus]

Don't move the stub to its own file. This will make phpunit complain about there being no tests in the file.

Normally that would make sense but we don't run any of the tests in this repo ourself so I don't see a very obvious issue here putting it in it's own file. We could also rename it to Dummy since it doesn't have any tests in it it shouldn't be called DummyTest (maybe TestDummy would have been more appropriate).

[Seldaek]

Makes sense that this should return a string to be a valid impl, but I think moving it out into its own file gives it the look that it's part of the official API vs an implementation detail. As it was it was kind of a "private" class, and I'd rather keep it that way.

[WyriHaximus]

but I think moving it out into its own file gives it the look that it's part of the official API vs an implementation detail. As it was it was kind of a "private" class, and I'd rather keep it that way.

We could mark it internal if that's the intend. But for this PR I'll revert that change 👍

[WyriHaximus]

@Seldaek updated the PR and undid the file extraction

[Seldaek]

Thanks

[WyriHaximus]

Cheers 👍

[Seldaek]

tagged 1.1.2 now

[WyriHaximus]

Thanks <3!