Add missing DOMCharacterData::appendData() return true description #2187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cmb69 Can I poke you to finish these last PRs? |
Girgias
reviewed
Feb 20, 2023
Member
|
If this is the case the stubs in php-src should also be updated to reflect this. |
Contributor
Author
|
The stub is type |
Member
IMHO it should, do you want to make the PR to php-src? |
Contributor
|
Guess I should have rebased that manually. Apparently the change had already been made, and the commit was a no-op. |
Member
|
Ah yeah, must have gone through in one of the other stubs syncs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type is bool not void and always returns true.