hash_file() appears to be restricted to 3 arguments

[maecompany]

Description

According to hash_file(), the function takes in 4 arguments, the latest one being an $options array, however it does not seem to accept 4 arguments.

The following code:

<?php echo hash_file('md5', '/dev/null', false, []); ?>

Resulted in this output:

PHP Fatal error:  Uncaught ArgumentCountError: hash_file() expects at most 3 arguments, 4 given

But I expected this output instead:

... some hash

Shouldn't the ZEND_PARSE_PARAMETERS_START(2, 3) actually be ZEND_PARSE_PARAMETERS_START(2, 4) here:

php-src/ext/hash/hash.c

Line 453 in 0e5ac62

ZEND_PARSE_PARAMETERS_START(2, 3)

?

PHP Version

PHP 8.1.18

Operating System

Ubuntu 23.04

[sschamp]

Looking at 110b4e9 it would indeed seem like an oversight where ZEND_PARSE_PARAMETERS_START was updated for hash() but not for hash_file()

[ndossche]

Feel free to submit a PR :)
EDIT: if you do not wish to make a PR let us know and we'll do the fix.
If you do want to make a PR, please also include a regression test. :)

[alecpl]

BTW, the mentioned commit that introduced the 4th argument also did not include a test for hash() call with 4 arguments. Unless I'm mistaken and it is not required when do a test using named arguments syntax.

[ndossche]

BTW, the mentioned commit that introduced the 4th argument also did not include a test for hash() call with 4 arguments. Unless I'm mistaken and it is not required when do a test using named arguments syntax.

The options argument only affects murmurhash right now, and there is a test for that.

I'll go ahead and fix hash_file and add a test.