parse_url() regression in php 8.2, no longer recognizes 'scheme:#fragement`

[Berdir]

Description

The following code:

<?php
var_dump(parse_url('internal:#feeding'));

Resulted in this output:

array(2) {
  ["path"]=>
  string(9) "internal:"
  ["fragment"]=>
  string(7) "feeding"
}

But I expected this output instead:

array(2) {
  ["scheme"]=>
  string(8) "internal"
  ["fragment"]=>
  string(7) "feeding"
}

See https://3v4l.org/nFqLN

This appears to a be a regression of #7844

PHP Version

PHP 8.2rc1

Operating System

No response

[Berdir]

Also broken with a query string: internal:?page=1000

[Berdir]

For more context, these is one of our failing unit tests: https://dispatcher.drupalci.org/job/drupal_patches/148448/testReport/junit/UrlTest/Drupal_Tests_Core_UrlTest/Drupal_Tests_Core_UrlTest/ (yes, it does involve feeding kittens).

And my ugly workaround: https://www.drupal.org/project/drupal/issues/3295821#comment-14693365

[andypost]

There's ext/standard/tests/strings/url_t.phpt which could be extended with this case

[andypost]

btw https://www.rfc-editor.org/rfc/rfc1738 said scheme: is not valid url

[Berdir]

magnet links seem to be broken by this as well, example: magnet:?xt=urn:sha1:YNCKHTQCWBTRNJIV4WNAE52SJUQCZO5C

[nyamsprod]

The regression also broke this example:

<?php
var_dump(parse_url('/example.com:42#foobar'));

Which now returns false in PHP8.2 instead of

<?
array(2) {
  ["path"]=>
  string(15) "/example.com:42"
  ["fragment"]=>
  string(6) "foobar"
}

[cmb69]

Yeah, we need to revert that "fix".

[cmb69]

Fixed as 2108d69.