Fix GH-10234: Setting DOMAttr::textContent results in an empty attribute value #10245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribute value. We can't directly call xmlNodeSetContent, because it might encode the string through xmlStringLenGetNodeList for types XML_DOCUMENT_FRAG_NODE, XML_ELEMENT_NODE, XML_ATTRIBUTE_NODE. In these cases we need to use a text node to avoid the encoding. For the other cases, we *can* rely on xmlNodeSetContent because it is either a no-op, or handles the content without encoding and clears the properties field if needed. The test was taken from the issue report, for the test: Co-authored-by: ThomasWeinert <[email protected]> Closes phpGH-10245.
Member
Author
|
Rebased this and added some more testing. Is there someone who's able to review this? :) |
Member
|
Maybe @Girgias? |
Member
|
@beberlei has done some stuff on DOM IIRC. I will try and have a look if they don't respond quickly. |
Contributor
|
I have honestly lost the grasp of libxml understandering at some point, it took me a few weeks to get into it the last time. I see this change has all the test assertions so from that perspective 😀 |
Girgias
approved these changes
May 29, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Let's just approve, worst case someone will report a new bug :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-10234
We can't directly call xmlNodeSetContent, because it might encode the string
through xmlStringLenGetNodeList for types
XML_DOCUMENT_FRAG_NODE, XML_ELEMENT_NODE, XML_ATTRIBUTE_NODE.
In these cases we need to use a text node to avoid the encoding.
For the other cases, we can rely on xmlNodeSetContent because it is either
a no-op, or handles the content without encoding and clears the properties
field if needed.