-
Notifications
You must be signed in to change notification settings - Fork 8k
Make globals const #10303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make globals const #10303
Conversation
|
cl.exe rightfully complains that the |
75f9ab6 to
c1a3d1f
Compare
|
Removed the redundant |
|
This looks sensible to me, but would like the opinion of someone else. |
c1a3d1f to
2a16562
Compare
|
cl.exe still isn't happy: Complaining about these two lines: I don't quite get it - but I'll drop that hunk to get the rest merged. |
2a16562 to
72b920d
Compare
|
Spurious Travis failure again, the rest is green. |
|
No objection on the mbstring part. I don't know what the maintainers of the other affected extensions think. |
72b920d to
4c6a6e7
Compare
|
@MaxKellermann Thanks for all the cleanup you are doing. |
|
The MacOS build seems to be broken somehow in CI: |
This looks like an unrelated spurious failure - this PR doesn't change anything with this header. |
ACK |
This moves them from
.datato.rodataand allows more compiler optimizations.