Skip to content

Handle non-INDIRECT symbol table entries in zend_fiber_object_gc() #10386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arnaud-lb merged 1 commit into from
Jan 27, 2023
Merged

Handle non-INDIRECT symbol table entries in zend_fiber_object_gc() #10386

arnaud-lb merged 1 commit into from
Jan 27, 2023

Conversation

@arnaud-lb
Copy link
Member

@arnaud-lb arnaud-lb commented Jan 20, 2023

Fixes #10340

@arnaud-lb arnaud-lb changed the base branch from master to PHP-8.1 January 20, 2023 12:45
@arnaud-lb arnaud-lb mentioned this pull request Jan 20, 2023
Closed
@arnaud-lb arnaud-lb marked this pull request as ready for review January 20, 2023 13:44
@arnaud-lb arnaud-lb requested a review from dstogov January 20, 2023 13:45
dstogov
dstogov approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right.

@arnaud-lb arnaud-lb merged commit 9830204 into php:PHP-8.1 Jan 27, 2023
arnaud-lb added a commit that referenced this pull request Jan 27, 2023
@arnaud-lb
Merge branch 'PHP-8.1' into PHP-8.2
ab2097d 
* PHP-8.1:
  Handle non-INDIRECT symbol table entries in zend_fiber_object_gc() (#10386)
arnaud-lb added a commit that referenced this pull request Jan 27, 2023
@arnaud-lb
Merge branch 'PHP-8.2'
ebf26af 
* PHP-8.2:
  Handle non-INDIRECT symbol table entries in zend_fiber_object_gc() (#10386)
@arnaud-lb
Copy link
Member Author

arnaud-lb commented Jan 27, 2023

@saundefined @patrickallaert could you backport this in 8.2.2 and 8.1.15 ?

This fixes a regression introduced in 8.2.2RC1 and 8.1.15RC1 by 4fb1493

@saundefined
Copy link
Member

saundefined commented Jan 27, 2023

@arnaud-lb thanks! I'll handle it for 8.2.2.

saundefined pushed a commit that referenced this pull request Jan 27, 2023
@arnaud-lb @saundefined
Handle non-INDIRECT symbol table entries in zend_fiber_object_gc() (#…
36d55f8 
…10386)

Fixes GH-10340
@patrickallaert
Copy link
Contributor

patrickallaert commented Jan 31, 2023 •
edited
Loading

@saundefined @patrickallaert could you backport this in 8.2.2 and 8.1.15 ?

Yes, it will be part of 8.1.15GA.

patrickallaert pushed a commit that referenced this pull request Jan 31, 2023
@arnaud-lb @patrickallaert
Handle non-INDIRECT symbol table entries in zend_fiber_object_gc() (#…
697dfb2 
…10386)

Fixes GH-10340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dstogov dstogov dstogov approved these changes

Assignees

No one assigned

Labels

Category: Engine

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion in zend_fiber_object_gc()

4 participants

@arnaud-lb @saundefined @patrickallaert @dstogov