random: Reduce variable scopes in CSPRNG #10426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to more easily reduce the scope of `n` in a future commit and now matches the getrandom(2) loop.
devnexen
reviewed
Jan 23, 2023
devnexen
approved these changes
Jan 23, 2023
Member
devnexen
left a comment
devnexen
left a comment
There was a problem hiding this comment.
ok by me let s see what other think
zeriyoshi
approved these changes
Jan 24, 2023
Girgias
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intentionally split across multiple tiny commits for review to make sure I didn't introduce any dumb mistakes.