Simplify php_reflection.c, class name cannot start with backslash #10536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Feb 7, 2023
| GET_REFLECTION_OBJECT_PTR(fptr); | ||
|
|
||
| zend_string *name = fptr->common.function_name; | ||
| const char *backslash = zend_memrchr(ZSTR_VAL(name), '\\', ZSTR_LEN(name)); |
Contributor
Author
There was a problem hiding this comment.
What is the best/fastest function to detect if one char is present?
Member
There was a problem hiding this comment.
zend_memrchr likely already is the fastest way.
iluuu1994
approved these changes
Feb 7, 2023
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Seems reasonable. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
class name is normalized in constructor, thus it cannot start with backslash and the detection if the backslash is thus not the first char is not needed