proc_open: reject array with empty command name #10559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proc_open([""], $ds, $pipes) is invalid, reject and warn.
Girgias
approved these changes
Feb 13, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Makes sense to me.
Can you add an entry in UPGRADING?
Contributor
Author
sure |
Contributor
Author
|
Done now |
Member
|
Thank you! |
crrodriguez
added a commit
to crrodriguez/php-src
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been split from #7933
proc_open([""], $ds, $pipes) is invalid, reject and raise an error if that happens.