Skip to content

Conversation

@MaxKellermann
Copy link
Contributor

No description provided.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only part I am unsure about is adding the const pointers to the compare handlers as this is an API break for extensions, and at least needs to be documented in UPGRADING.INTERNALS.

Therefore could you spin it out into a seperate PR? Because if we start chaning the object handler API it probably makes sense to change int returns to zend_result or bool as well.

@MaxKellermann
Copy link
Contributor Author

Therefore could you spin it out into a seperate PR?

Aye. I splitted the first commit and removed lots of hunks, leaving only the ones that are necessary for the following commits.

Because if we start chaning the object handler API it probably makes sense to change int returns to zend_result or bool as well.

That part of the API bothered me as well, but yes, maybe I'll make a new PR which refactors everything to use proper types and proper const-ness.

@Girgias Girgias merged commit 49c1e6e into php:master Feb 20, 2023
@MaxKellermann MaxKellermann deleted the const_pointers branch March 7, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants