Zend/zend_globals: convert fiber_stack_size to size_t
#10619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`zend_long` is a signed integer that's only 32 bit on some 64 bit architectures (e.g. ARM64). The proper type for memory sizes is `size_t`, and this type is accepted by zend_fiber_init_context().
trowski
approved these changes
Feb 18, 2023
Member
|
Thanks ! |
crrodriguez
pushed a commit
to crrodriguez/php-src
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zend_longis a signed integer that's only 32 bit on some 64 bit architectures (e.g. ARM64). The proper type for memory sizes issize_t, and this type is accepted by zend_fiber_init_context().