Simplify checks and returns in ext/xmlwriter #10701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Feb 25, 2023
ext/xmlwriter/php_xmlwriter.c
Outdated
| retval = internal_function(ptr, (xmlChar *) name); | ||
|
|
||
| RETURN_FALSE; | ||
| RETVAL_BOOL(retval != -1); |
* The ptr check is redundant because XMLWRITER_FROM_OBJECT will return if ptr is NULL. * Use RETURN_BOOL to simplify the return code.
Girgias
approved these changes
Feb 26, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Jesus that was some convoluted code which was hard to read.
Thanks for the improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.