Fix GH-10801: Named arguments in CTE functions cause a segfault

[ndossche]

Fixes GH-10801

Named arguments are not supported by the constant evaluation routine, in the sense that they are ignored. This causes two issues:

• It causes a crash because not all oplines belonging to the call are removed, which results in SEND_VA{L,R} which should've been removed.
• It causes semantic issues (demonstrated in the test case).

This case never worked anyway, leading to crashes or incorrect behaviour, so just prevent CTE of calls with named parameters for now. We can choose to support it later, but introducing support for this in a stable branch seems too dangerous.

This patch does not change the removal of SEND_* opcodes in remove_call because the crash bug can't be triggered anymore with this patch as there are no named parameters anymore and no variadic CTE functions exist.

Question

I do have the patch already on my machine to support named arguments & variadics in the remove_call function, which solves bullet point 1. If we're interested in supporting named arguments in CTE, I can write the code to actually pass the named arguments during CTE, which would solve bullet point 2. This would make CTE possible with named arguments. Is this something we want?

[mvorisek]

From user perspective, I expect no behavioural/CTE change when I use named parameters.

[ndossche]

There was a behavioural change prior to this PR because the support for named parameters was not there but the optimizer expected it to work.
As I mentioned in the "question" section, I'm willing to add support for named parameters, but only on master as touching the optimizer for stable versions is somewhat dangerous.

[iluuu1994]

Thank you! LGTM.

Is this something we want?

Unless the implementation is complex consistency would make sense.