Add string output escaping into zend dump (phpdbg + opcache debug) #11337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
reviewed
May 29, 2023
iluuu1994
reviewed
May 29, 2023
dstogov
reviewed
May 29, 2023
Member
dstogov
left a comment
dstogov
left a comment
There was a problem hiding this comment.
This makes sense. Please follow @iluuu1994's suggestions.
Contributor
Author
|
Should I also add a note about these changes to the NEWS file? |
Member
|
I think this is not necessary. |
Contributor
Author
|
The tests passed, but some fails. I suspect that these tests are not related to changes to the PR. |
Member
|
I checked, the two failures are spurious indeed. |
dstogov
approved these changes
May 29, 2023
|
Hi, folks, I would like to make an enhencement on zend dump for string which related to this pull requests, could you guys please kindly leave some suggestions. Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10576