Keep consistent EG(current_execute_data) after return from generator #11380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwoebi
approved these changes
Jun 6, 2023
Member
bwoebi
left a comment
bwoebi
left a comment
There was a problem hiding this comment.
Apart from ensuring consistency, this also has the side effect, that variable destruction occurs on top of the the previous frame, which is consistent with zend_leave_helper behaviour.
5 tasks
Member
Author
|
The main problem - zend_generator_close() may free execute_data and make EG(current_execute_data) to be a dangling pointer. |
dstogov
added a commit
that referenced
this pull request
Jun 8, 2023
* PHP-8.1: Keep consistent EG(current_execute_data) after return from generator (#11380)
dstogov
added a commit
that referenced
this pull request
Jun 8, 2023
* PHP-8.2: Keep consistent EG(current_execute_data) after return from generator (#11380)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.