Remove unused PHP_HASH variable #11653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was used when hash extension wasn't always available.
iluuu1994
reviewed
Jul 10, 2023
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Thank you! There's also a declaration in ext/hash/config.w32, do we need that one still?
Member
Author
Yes, that one in the config.w32 is ok. It sets the extension to enabled by overriding the omitted ARG_ENABLE call. Otherwise, these .m4 files would also need the PHP_{EXTNAME} to be set but luckily the check in php.m4 somewhere is built in a way that they are not needed. |
Member
|
@petk Thanks! I don't understand autoconf well so sorry to not be of much help. 😄 |
Member
Author
|
I've merged this one also then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was used when hash extension wasn't always available.