Fix use-of-uninitialized-value in start_fake_frame #11732
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
force-pushed
the
fix-uouv-in-start_fake_frame
branch
from
9f245b8 to
74b014b
Compare
arnaud-lb
approved these changes
Jul 22, 2023
Member
arnaud-lb
left a comment
arnaud-lb
left a comment
There was a problem hiding this comment.
Looks good to me. We may as well initialize it to EG(current_execute_data) (all code paths do it after that).
BTW, was it detected by MSAN? While looking at #9933, I've noticed that since zend_vm_stack_push_call_frame reuses frames, uninitialized VM stack memory may not appear as uninitialized to MSAN. I don't know if we could change that by using __msan_allocated_memory().
Member
Author
|
@arnaud-lb Yes, found via MSAN with Clang 16. Allocating call frames with malloc while using MSAN or even ASAN for bounds checking sounds like a good idea! |
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.