Fix GH-10964: Improve man page about the built-in server
#11857
Conversation
|
Fwiw, CI failed because of a deprecation that has been fixed in the meantime, but as you still use a very old 8.1 branch it's still there for you. Although it doesn't matter for this contribution, I think it's a good idea to update your local branches with upstream in case you want to do future contributions. |
alexandre-daubois
force-pushed
the
improve-man-page
branch
from
e8ce622 to
c5cd0a8
Compare
|
Oh yes, I thought I was up-to-date with the upstream. 8.1 is caught-up now 🙂 |
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Minor nits, otherwise seems good to me. Thanks for tackling this!
sapi/cli/php.1.in
Outdated
| .LP | ||
| If a PHP file is provided to the command line when the | ||
| built-in web server is used, it will be ued as the router script. This script | ||
| will be started at each HTTP request. The script output will is returned to the |
There was a problem hiding this comment.
| will be started at each HTTP request. The script output will is returned to the | |
| will be started at each HTTP request. The script output is returned to the |
There was a problem hiding this comment.
Both comments addressed, thanks! 🙂
sapi/cli/php.1.in
Outdated
| passed by the \-t option. | ||
| .LP | ||
| If a PHP file is provided to the command line when the | ||
| built-in web server is used, it will be ued as the router script. This script |
There was a problem hiding this comment.
| built-in web server is used, it will be ued as the router script. This script | |
| built-in web server is used, it will be used as the router script. This script |
sapi/cli/php.1.in
Outdated
| browser, unless the router script returns the | ||
| .B false | ||
| value. If so, the built-in server falls back to the default behaviour, returning | ||
| the requested resource as-is by looking-up the files relative to the document |
There was a problem hiding this comment.
I think that it should be looking up instead of looking-up.
There was a problem hiding this comment.
Updated, thanks Javier! 😃
alexandre-daubois
force-pushed
the
improve-man-page
branch
from
c5cd0a8 to
fa35dc9
Compare
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
LGTM, Thanks.
I'll take it in my merge queue for tonight.
3 participants
Fix #10964