Revert the fix for GH-11498 #11863
Closed
Revert the fix for GH-11498 #11863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People relied on manually waiting for children, but the fix for phpGH-11498 broke this. Fixing this in PHP is fundamentally incompatible with doing the wait loop in userland. This reverts to the old behaviour.
ndossche
force-pushed
the
revert-pcntl-signal-change
branch
from
3e817a6 to
9ae65a0
Compare
iluuu1994
approved these changes
Aug 2, 2023
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Thank you! May we keep the test and adjust it to use pcntl_wait instead? Then we at least gained something from this change and won't accidentally break this again in the future. 🙂
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 16, 2023
People relied on manually waiting for children, but the fix for phpGH-11498 broke this. Fixing this in PHP is fundamentally incompatible with doing the wait loop in userland. This reverts to the old behaviour. Closes phpGH-11863.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People relied on manually waiting for children, but the fix for GH-11498 broke this. Fixing this in PHP is fundamentally incompatible with doing the wait loop in userland. This reverts to the old behaviour.
We should document the behaviour though in the manual, after merging this I'll take a look for doing that.