Improve database naming in ext/pdo_pgsql for better para-tests
#11872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Aug 4, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
I like the idea, but dropping the table should be done in a --CLEAN-- section
| $db->exec('CREATE TABLE test (foo varchar(5) NOT NULL, bar bool NOT NULL)'); | ||
| $db->exec("INSERT INTO test VALUES('false','f')"); | ||
| $db->exec("INSERT INTO test VALUES('true', 't')"); | ||
| $db->query('DROP TABLE IF EXISTS b33876 CASCADE'); |
Member
There was a problem hiding this comment.
Those DROP TABLES should be in a CLEAN section
Member
|
Ah wait, this is in tandem with the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @Girgias' comment (#11855 (comment)), I propose this PR to improve tests under
ext/pdo_pgsqlby renaming tables. Each table takes the test name, making them unique which is better to run tests in parallel.If this gets merged, I'll try to have a look at other drivers! 🙂