Fix parent check and viable next sibling search for replaceWith #11888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndossche
force-pushed
the
fix-replacewith-again
branch
from
44fb384 to
65efb49
Compare
Girgias
approved these changes
Aug 7, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
This LGTM from my very basic understanding of the DOM spec
|
|
||
| void dom_child_replace_with(dom_object *context, zval *nodes, int nodesc) | ||
| { | ||
| /* Spec link: https://dom.spec.whatwg.org/#dom-childnode-replacewith*/ |
Member
There was a problem hiding this comment.
Nit:
Suggested change
| /* Spec link: https://dom.spec.whatwg.org/#dom-childnode-replacewith*/ | |
| /* Spec link: https://dom.spec.whatwg.org/#dom-childnode-replacewith */ |
| @@ -0,0 +1,36 @@ | |||
| --TEST-- | |||
| replaceWith() with a non-variable next sibling | |||
Member
There was a problem hiding this comment.
Nit:
Suggested change
| replaceWith() with a non-variable next sibling | |
| replaceWith() with a non-viable next sibling |
ndossche
added a commit
that referenced
this pull request
Aug 7, 2023
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can land the parent check fix in master for the BC.