Skip to content

GH-11964: In ext/date/php_date.stub.php, DateRangeError extends itself #11965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ndossche merged 1 commit into from
Aug 14, 2023
Merged

GH-11964: In ext/date/php_date.stub.php, DateRangeError extends itself #11965

ndossche merged 1 commit into from
Aug 14, 2023

Conversation

@ndossche
Copy link
Member

@ndossche ndossche commented Aug 14, 2023

According to the RFC[1] it's supposed to extend DateError.

[1] https://wiki.php.net/rfc/datetime-exceptions

Closes GH-11964

@ndossche ndossche requested a review from derickr as a code owner August 14, 2023 11:24
iluuu1994
iluuu1994 approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks consistent with

php-src/ext/date/php_date.c

Line 1832 in 67ab2b7

date_ce_date_range_error = register_class_DateRangeError(date_ce_date_error);

Thanks!

@ndossche ndossche merged commit 17b3af2 into php:master Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@derickr derickr Awaiting requested review from derickr derickr is a code owner

Assignees

No one assigned

Labels

Extension: date

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In ext/date/php_date.stub.php , DateRangeError extends itself

2 participants

@ndossche @iluuu1994