gen_stub: fix regexps with unintentional range due to - character placement
#12004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[A-Za-z0-9_-|]regex range is interpreted as any character in rangesA-Z,a-z,0-9, and_-|. The last three characters (_-|) are interpretted as a range, because the dash character is placed between_and|. This means the regexp matches any ASCII character between ASCII index 95 and 124. This means that this expression unexpectedly (?) matches characters such as\`` and{`This changes the regexp to place the dash character at the end, so instead of any character in ASCII 95-124, it only matches
-,|, and_characters only.Regex101 also highlighting this: https://regex101.com/r/gEq3wc/1