Typed constants in PDO extension #12362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
reviewed
Oct 6, 2023
Member
kocsismate
left a comment
kocsismate
left a comment
There was a problem hiding this comment.
LGTM as well, but I'm curious about the opinion of others
kocsismate
reviewed
Oct 8, 2023
| class PDO | ||
| { | ||
| /** | ||
| * @cvalue LONG_CONST(PDO_PARAM_NULL) |
kocsismate
approved these changes
Oct 8, 2023
jorgsowa
force-pushed
the
typed-constants-in-pdo-extension
branch
from
180d664 to
4756ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the types to the constants in PDO extension.