Implement iterative Pearce's SCC finding algoritm #12528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I propose to merge this into master and back-port to old PHP branches after testing. |
ndossche
approved these changes
Oct 26, 2023
| case 7: use = iterator->use; goto state_7; | ||
| case 8: use = iterator->use; goto state_8; | ||
| case 9: phi = iterator->phi; goto state_9; | ||
| case 10: phi = iterator->phi; goto state_10; |
Member
There was a problem hiding this comment.
Label state_10 is only defined in #ifdef SYM_RANGE. So this case must also be guarded with #ifdef SYM_RANGE.
dstogov
added a commit
that referenced
this pull request
Oct 31, 2023
dstogov
added a commit
that referenced
this pull request
Oct 31, 2023
* PHP-8.1: Backport implementation of iterative Pearce's SCC finding algoritm (#12528)
dstogov
added a commit
that referenced
this pull request
Oct 31, 2023
* PHP-8.2: Backport implementation of iterative Pearce's SCC finding algoritm (#12528)
dstogov
added a commit
that referenced
this pull request
Oct 31, 2023
* PHP-8.3: Backport implementation of iterative Pearce's SCC finding algoritm (#12528)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11795
The proposed algorithm is a variation of Algorithm 4 described in https://whileydave.com/publications/Pea16_IPL_preprint.pdf . However this description has a bug (vS stack should be split into two stacks).
The fixed reference implementations are available at https://github.com/DavePearce/StronglyConnectedComponents