Skip to content

Conversation

@kamil-tekiela
Copy link
Member

Is it ok to change it in these places?

@cmb69
Copy link
Member

cmb69 commented Aug 1, 2021

I'm not quite sure about the changes to ext/opcache/jit/**; these appear to be bundled libraries, so updating (if that ever happens) might be slightly harder; might be a good idea to provide these fixes upstream (if those libraries are still maintained). The rest looks definitely good to me.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kamil-tekiela kamil-tekiela merged commit cd0cd3d into php:master Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants