List skipped extensions in run-tests.php

[mvorisek]

discovered in #8348 - Tests skipped because of missing ext were listed nowhere, this change improves the testing output by listing the skipped exts.

discovered in #8363 (comment) - The

php-src/run-tests.php

Line 890 in c809a21

if (!extension_loaded($ext) && @dl($file)) {

was producing silently ignored! fatal error due #9196 (as the loaded exts were echoed at the start, the problem remained hidden, with this PR, we echo at the end, and fatal error will imply no loaded ext will be detected at all - easy to notice any problem)

also, we centralize the place where we normalize the loaded ext names to ext so/dll filenames

[mvorisek]

why is zend_test listed there? can skeleton be build/tested as well?

[cmb69]

zend_test is a real extension (used to be able to test stuff which would otherwise be untestable). skeleton is just a template for an extension, and as such cannot be build.

[mvorisek]

zend_test is a real extension (used to be able to test stuff which would otherwise be untestable)

I know, but why it is listed as untested?

skeleton is just a template for an extension, and as such cannot be build.

if we would replace %EXTNAMECAPS% with SKELETON (and %EXTNAME% and similar template vars)?

[cmb69]

I know, but why it is listed as untested?

Likely because zend_tests is not loaded, when $exts_to_test is initialized. I think this might be solved by targeting the master branch, what such improvements should do anyway.

if we would replace %EXTNAMECAPS% with SKELETON (and %EXTNAME% and similar template vars)?

Why not simply exclude this extension from those stats?

[mvorisek]

I will look what I can do for master, can this PR be merged to PHP 8.0 as is?

[cmb69]

I don't think this should go into any of the stable branches.

[cmb69]

Also please have a look at https://ci.appveyor.com/project/php/php-src/builds/44737578/job/tg57sktu8c5i6oyl#L1690. The ext\opcache\tests should be executed for this configuration.

[mvorisek]

Also please have a look at https://ci.appveyor.com/project/php/php-src/builds/44737578/job/tg57sktu8c5i6oyl#L1690. The ext\opcache\tests should be executed for this configuration.

there are two jobs, opcache should probably be NOT executed for OPCACHE=0 job

but good catch, the OPCACHE=1 job is skipping all exts [1], do you have any idea why? Does dl() supports ZTS?

[1] https://ci.appveyor.com/project/php/php-src/builds/44737578/job/5e6uc64ft1vl4cty#L1706

[mvorisek]

PR is done

[mvorisek]

@cmb69 adjusted for your #9557, if there are no more objections, please squash into one commit and merge

[cmb69]

Thank you!

[iluuu1994]

This causes the following error for me:

Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /home/ilutov/Developer/php-src/run-tests.php:3054
Stack trace:
#0 /home/ilutov/Developer/php-src/run-tests.php(726): compute_summary()
#1 /home/ilutov/Developer/php-src/run-tests.php(4019): main()
#2 {main}
  thrown in /home/ilutov/Developer/php-src/run-tests.php on line 3054
make: *** [Makefile:209: test] Error 255

where $ignored_by_ext is NULL.

[cmb69]

Hmm, on a quick glance, I think we need to initialize $ignored_by_ext earlier. I'll have a closer look tomorrow.

[cmb69]

#9617 should fix the issue.