Add some const qualifiers in HashTable foreach macros #8671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't apply the
constmodifier to theZEND_HASH_MAP_REVERSE_FOREACH()macro as it is sometimes ended with theZEND_HASH_MAP_FOREACH_END_DEL()which deletes entries from the HashTable (thus clearly violating theconstqualifier).I stumbled upon this when I wanted to add a
constqualifier in PECL/csv to a HashTable that I don't modify and just traverse. But the fact thatZEND_HASH_MAP_FOREACH_END_DEL()exists makes me unsure how to proceed.