Fix bug #67764: fpm: syslog.ident does not work #8780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a more structured implementation of #7334 and also applies it on PHP
closelogfunction. The aim is to just make sure thathave_called_openloggets reset on each closelog.I have been also thinking about a possible test but that would be just too flaky and only available to very limited set of platform (e.g. where /var/log/syslog is available and readable). So it wouldn't work in the pipeline anyway. Instead I just used a manual test for testing that this works that can be seen at https://github.com/bukka/php-util/tree/09f5c2e30d877d48e979514d8d1c602d1a8336ae/tests/fpm/syslog-ident .