Fix GH-8924 str_split of empty string must return empty array #8945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
reviewed
Jul 7, 2022
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thank you for the PR! In my opinion, this is okay for master.
Co-authored-by: Christoph M. Becker <[email protected]>
cmb69
approved these changes
Jul 7, 2022
Member
|
Should the change be documented ? |
Member
Besides the usual entry in NEWS, there should be a brief note in UPGRADING, so that the doc team can later put that into the migration guide. |
iluuu1994
added a commit
to iluuu1994/php-src
that referenced
this pull request
Jul 14, 2022
Introduced in phpGH-8945 With RETURN_EMPTY_ARRAY this function can now return an interned array which has refcount 2.
iluuu1994
added a commit
that referenced
this pull request
Jul 15, 2022
Introduced in GH-8945 With RETURN_EMPTY_ARRAY this function can now return an interned array which has refcount 2.
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inconsistency was introduced in 0818fae by a mistake as found out by @emkey08.
mb_str_splitbehaves properly and empty input is covered by a test already.As some algorithms might rely on the bad - always non-empty array - behaviour, targetting master only.