PcgOneseq128XslRr64::jump(): Throw ValueError for negative $advance #9213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
Jul 31, 2022
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
Thank you for the patch! Can you add a test, similar to https://github.com/php/php-src/blob/master/ext/random/tests/02_engine/mt19937_error.phpt? pcgoneseq128xslrr64_jump_error.phpt should be an appropriate name.
kocsismate
reviewed
Jul 31, 2022
Contributor
Author
done |
zeriyoshi
approved these changes
Aug 1, 2022
Contributor
zeriyoshi
left a comment
zeriyoshi
left a comment
There was a problem hiding this comment.
It looks good. Thanks.
I was neglecting to take this into consideration.
kocsismate
reviewed
Aug 1, 2022
kocsismate
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9212