Clean up the implementation of Randomizer::__construct() #9222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of manually checking whether the constructor was already called, we rely on the `readonly` modifier of the `$engine` property. Additionally use `object_init_ex()` instead of manually calling `->create_object()`.
TimWolla
commented
Aug 1, 2022
| zend_update_property(random_ce_Random_Randomizer, Z_OBJ_P(ZEND_THIS), "engine", strlen("engine"), &engine); | ||
|
|
||
| ZVAL_OBJ(&zengine_object, engine_object); | ||
| OBJ_RELEASE(Z_OBJ_P(&engine)); |
Member
Author
There was a problem hiding this comment.
Should this be zval_ptr_dtor() instead?
Member
There was a problem hiding this comment.
OBJ_RELEASE is fine IMHO, as it prevents some indirection which would boils down to the same code
Contributor
There was a problem hiding this comment.
I don't know much about it, but from what I've read, OBJ_RELEASE should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually checking whether the constructor was already called, we rely on the
readonlymodifier of the$engineproperty.Additionally use
object_init_ex()instead of manually calling->create_object().I'm not at all sure that the implementation is correct, but it passes the tests locally both with Zend MM and valgrind.