Fix unexpected deprecated dynamic property warning #9324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occurred when exit() with uncaught exception in finally block.
Member
Author
cmb69
approved these changes
Aug 15, 2022
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thank you for the PR! I think this is the proper way to solve this; the alternative of declaring the property on UnwindExit and GracefulExit probably makes no sense.
Member
Author
|
@cmb69 Thanks for your review! Feel free to merge this whenever you see fit. |
Member
|
@twose, you already should have commit karma. :) |
Member
Author
|
@cmb69 Fine, just thought it would be more standardized if the pull request was merged by the reviewer, I may make some grammar mistakes in commit messages sometimes... Also feel free to correct me in time if you notice that. :) |
Member
|
@twose Should this be added to NEWS? |
twose
added a commit
that referenced
this pull request
Aug 15, 2022
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occurred when exit() with uncaught exception in finally block.