Remove useless UNEXPECTED around RETURN_VALUE_USED in specialized RETVAL handler

[iluuu1994]

This can lead to funny code like UNEXPECTED(1) which is non-sensical.

SPEC(QUICK_ARG) can cause the same issue with UNEXPECTED(arg_num <= MAX_ARG_FLAG_NUM) but it's not as straight-forward to fix as it doesn't get replaced in all handlers.

[cmb69]

This can lead to funny code like UNEXPECTED(1) which is non-sensical.

It would only be bad, if RETURN_VALUE_USED(opline) evaluated to 0 most of the time. I think we either should measure, or rely on PGO (although I'm not sure whether "good" PGO builds are very common).

[iluuu1994]

@cmb69 Note that RETURN_VALUE_USED(opline) is not the code that is actually compiled, as it's replaced with 0/1 in zend_vm_execute.h by zend_vm_gen.php for these specialized handlers.

[cmb69]

Ah, thanks, of course!

[iluuu1994]

@cmb69 Thanks for the review 🙂

[iluuu1994]

I reverted this change (81f3fcd). I was unaware of the --without-specializer flag in which case the UNEXPECTED might still be helpful.