Skip to content

Conversation

@devnexen
Copy link
Member

@devnexen devnexen commented Oct 2, 2022

…r kernels.

As mentioned in its manpage, it had been reworked in the 5.3 line to support cross filesystem interactions.

@devnexen devnexen force-pushed the copy_file_range_disable_for_old_kernels branch from f005046 to 418e0fc Compare October 2, 2022 12:30
@devnexen devnexen force-pushed the copy_file_range_disable_for_old_kernels branch from c3392d4 to fc97cf5 Compare October 6, 2022 18:14
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks reasonable, just few NITS...

configure.ac Outdated

AC_CACHE_CHECK([for copy_file_range], ac_cv_copy_file_range,
[AC_RUN_IFELSE([AC_LANG_SOURCE([[
#if defined(__linux__)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#if defined(__linux__)
#ifdef __linux__

@devnexen devnexen force-pushed the copy_file_range_disable_for_old_kernels branch from fc97cf5 to 4d30a3c Compare October 6, 2022 19:05
…lder kernels.

As mentioned in its manpage, it had been reworked in the 5.3 line to support cross filesystem interactions.
@devnexen devnexen force-pushed the copy_file_range_disable_for_old_kernels branch from 4d30a3c to fa57cd8 Compare October 6, 2022 19:06
@devnexen
Copy link
Member Author

@bukka how does it look to you now ?

@bukka
Copy link
Member

bukka commented Oct 11, 2022

Looks good

devnexen added a commit that referenced this pull request Oct 11, 2022
…r kernels.

As mentioned in its manpage, it had been reworked in the 5.3 line to support cross filesystem interactions.
Closes #GH-9656
@devnexen
Copy link
Member Author

Merged as c15fe519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants