RFC: Add #[Override] attribute #9836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
TimWolla
force-pushed
the
override-attribute
branch
2 times, most recently
from
a4606e7 to
9196c03
Compare
iluuu1994
reviewed
Apr 27, 2023
TimWolla
force-pushed
the
override-attribute
branch
from
4c9d9d0 to
d48a195
Compare
Member
Author
|
The RFC is accepted and the failing tests appear to be unrelated. |
Member
Author
|
Okay, I believe I made all the requested changes (and hopefully correctly). Please double-check it. If it's good I'll add NEWS / UPGRADING notes myself and merge. |
iluuu1994
approved these changes
Jun 29, 2023
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Yes, this looks fine, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/marking_overriden_methods