Skip to content

Conversation

@kamil-tekiela
Copy link
Contributor

Also add native param types and return types.

@kamil-tekiela kamil-tekiela force-pushed the Incorrect-return-type branch from d18ffce to 128d530 Compare May 31, 2023 19:06
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (64090cb) 96.66% compared to head (22b2cb8) 96.66%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #452   +/-   ##
=========================================
  Coverage     96.66%   96.66%           
  Complexity     2198     2198           
=========================================
  Files            67       67           
  Lines          5062     5062           
=========================================
  Hits           4893     4893           
  Misses          169      169           
Impacted Files Coverage Δ
src/Utils/CLI.php 97.93% <100.00%> (ø)
src/Utils/Tokens.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Kamil Tekiela <[email protected]>
@kamil-tekiela kamil-tekiela force-pushed the Incorrect-return-type branch from 523e852 to 22b2cb8 Compare May 31, 2023 21:16
@williamdes williamdes added this to the 6.0.0 milestone May 31, 2023
@williamdes williamdes self-assigned this May 31, 2023
@williamdes williamdes merged commit a7a57cd into phpmyadmin:master May 31, 2023
@kamil-tekiela kamil-tekiela deleted the Incorrect-return-type branch June 7, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants