Skip to content

Fix #5369: [java] Consider that lombok.val and var are inferred #5554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adangel merged 8 commits into from
Mar 13, 2025
Merged

Fix #5369: [java] Consider that lombok.val and var are inferred #5554

adangel merged 8 commits into from
Mar 13, 2025

Conversation

@oowekyala
Copy link
Member

@oowekyala oowekyala commented Feb 27, 2025 •
edited
Loading

Describe the PR

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@ghost
Copy link

ghost commented Feb 27, 2025 •
edited by ghost
Loading

1 Message
📖 Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 1 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
✅ Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 1 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
✅ Compared to main:
This changeset changes 0 violations,
introduces 1 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact
✅ Compared to main:
This changeset changes 0 violations,
introduces 1 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@oowekyala oowekyala marked this pull request as ready for review March 10, 2025 00:12
@adangel adangel changed the title [java] Fix #5369 - Consider that lombok.val and var are inferred Fix #5369: [java] Consider that lombok.val and var are inferred Mar 13, 2025
adangel
adangel reviewed Mar 13, 2025
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'll update docs, release notes, version reference and add a test case for #5369 explicitly and merge afterwards.

@adangel adangel added this to the 7.12.0 milestone Mar 13, 2025
@adangel adangel mentioned this pull request Jan 23, 2023
Open
@github-actions
Copy link

github-actions bot commented Mar 13, 2025

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.

Regression Tester Report

adangel added a commit that referenced this pull request Mar 13, 2025
@adangel
Fix #5369: [java] Consider that lombok.val and var are inferred (#5554)
5a945d2 
Merge pull request #5554 from oowekyala:issue5369-lombok-inference
@adangel adangel merged commit 1631f3f into pmd:main Mar 13, 2025
12 checks passed
@oowekyala oowekyala deleted the issue5369-lombok-inference branch March 13, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adangel adangel adangel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

7.12.0

Development

Successfully merging this pull request may close these issues.

[java] UnusedPrivateMethod false positives with lombok.val

2 participants

@oowekyala @adangel