[core] Reduce memory usage of CPD's MatchCollector #6150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
When analyzing the heap dump created by running CPD against https://github.com/alsa-project/alsa-firmware/blob/master/emu/emu0404_netlist.h (mentioned in #6145) with Eclipse's Memory Analzyer, there's a clear culprit for the huge memory consumption in CPD: net.sourceforge.pmd.cpd.MatchCollector#tokenMatchSets
tokenMatchSetsis a Map that stores lots ofSet<Integer>as its values, which can take up most of the available heap space. There's a drop-in replacement for usingSet<Integer>here, that takes up significantly less memory:java.util.Bitset.When using PMD 7.17, I wasn't able to run CPD on
emu0404_netlist.hwith--minimum-tokens 100, even with a max heap size of 8GB.Using my locally built SNAPSHOT with
BitSet, I was able to analyzeemu0404_netlist.h, while only consuming about ~750MB of memory.Which means in this scenario, this simple replacement reduces the memory footprint of CPD to less than a tenth compared to 7.17.
Related issues
Ready?
./mvnw clean verifypasses (checked automatically by github actions)