[java] Fix #6096: Detect Lombok generated equals/hashCode in Comparable

[mrclmh]

Describe the PR

Rule: OverrideBothEqualsAndHashCodeOnComparable

Detect generated equals and hashCode in Comparable when neither method has been implemented manually.
Currently Lombok @EqualsAndHashCode, @Data and @Value are detected.

Related issues

• Fix [java] OverrideBothEqualsAndHashCodeOnComparable on class with lombok.EqualsAndHashCode annotation #6096
• Related to [java] OverrideBothEqualsAndHashCodeOnComparable should not be required for record classes #6072 and [java] Fix #6072: OverrideBothEqualsAndHashCodeOnComparable should not be required for record classes #6081 - same issue for records
• See also [java] Better Lombok support #3119

Ready?

• Added unit tests for fixed bug/feature
• Passing all unit tests
• Complete build ./mvnw clean verify passes (checked automatically by github actions)
• Added (in-code) documentation (if needed)

[pmd-actions-helper]

Documentation Preview

Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 25 errors and 8 configuration errors.

Regression Tester Report

(comment created at 2025-11-20 21:01:40+00:00 for 8ab254e)

[mrclmh]

Not sure about the line break in the Set init line. What is the preferred max line length for the project?

[adangel]

Thanks for the PR!

This will solve it for that rule.

---

optional request:
For Lombok, we actually have a bit more in mind (see #3119):

• in

  pmd/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/internal/ast/AstClassSym.java

  Line 158 in 33f00ec

  public void processLombok(JavaAstProcessor processor) {

  we could actually add fake methods for the generated equals and hashCode methods
• in

  pmd/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/errorprone/OverrideBothEqualsAndHashcodeRule.java

  Line 35 in 33f00ec

  for (ASTMethodDeclaration m : node.getDeclarations(ASTMethodDeclaration.class)) {

  the rule wouldn't iterate over the ast, but over the symbols (using node.getSymbol().getDeclaredMethods()) and would see then the generated methods as well

If you like, you can give it a try, maybe in a separate PR.

---

[adangel]

Not sure about the line break in the Set init line. What is the preferred max line length for the project?

around 120 I think

[adangel]

Thanks!