Prevent asyncio DeprecationWarning #1291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some circumstances (see <xonsh/xonsh#3907>) a DeprecationWarning would be printed. This is because of passing coroutine objects directly to asyncio.wait(), which is confusing behaviour that has been deprecated. <python/cpython#9543> gives information on how to refactor code that uses the deprecated method. Signed-off-by: Carmen Bianca Bakker <[email protected]>
Contributor
Author
|
Ah… Broken under 3.6. asyncio.create_task was only introduced in 3.7. Not sure what the preferred method of fixing this is. This could possibly do it if I'm not mistaken: try:
from asyncio import create_task
except ImportError:
create_task = lambda x: xBut that's obviously a bit hacky. Happy to take input :) |
Member
|
Can we use |
create_task() is not available for Python <3.7. Signed-off-by: Carmen Bianca Bakker <[email protected]>
Contributor
Author
|
@jonathanslenders That appears to work, although the documentation for ensure_future() is esoteric magic to me. |
Member
|
Thank you @carmenbianca ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some circumstances (see xonsh/xonsh#3907) a DeprecationWarning would be printed. This is because of passing coroutine objects directly to asyncio.wait(), which is confusing behaviour that has been deprecated.
python/cpython#9543 gives information on how to refactor code that uses the deprecated method.
Fixes xonsh/xonsh#3907