Drop Python 3.6. #1721
Merged
Drop Python 3.6. #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanslenders
force-pushed
the
dropping-python3.6
branch
2 times, most recently
from
7fa079c to
1ea88a5
Compare
Use `asyncio.get_running_loop()` and `asyncio.run()`. Stop using `asyncio.get_event_loop()` and `asyncio.set_event_loop()`.
jonathanslenders
force-pushed
the
dropping-python3.6
branch
from
1ea88a5 to
5deb91e
Compare
find -name '*.py' -exec pyupgrade --py37-plus '{}' \;
Member
Author
|
If anyone here has a Windows environment available, it would be much appreciated if this could be tested. |
This is a better than having a separate .start() and .stop() when it comes to cancellation.
jonathanslenders
force-pushed
the
dropping-python3.6
branch
from
7285ac3 to
ae0db0a
Compare
Member
Author
|
Going to merge this, I tested on Windows. There are some mypy issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
asyncio.get_running_loop()andasyncio.run(). Stop usingasyncio.get_event_loop()andasyncio.set_event_loop().