Skip to content

Fix ToolCache.find and add #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomashoneyman merged 11 commits into from
Sep 22, 2020
Merged

Fix ToolCache.find and add #8

thomashoneyman merged 11 commits into from
Sep 22, 2020

Conversation

@colinwahl
Copy link
Member

@colinwahl colinwahl commented Sep 22, 2020

Description of the change

  • Fixes a typo in the FFI implementation of the GitHub.Actions.ToolCache.find and GitHub.Actions.ToolCache.find functions
  • Adds a test action which runs on commit to a branch (or PR)
    • This will be useful in Add comprehensive Test #5 as a simple test script isn't enough - it needs to actually run the action through a real workflow

This intends to close #7.

@colinwahl colinwahl self-assigned this Sep 22, 2020
thomashoneyman
thomashoneyman approved these changes Sep 22, 2020
View reviewed changes
src/GitHub/Actions/ToolCache.js
exports.cacheFile5Impl = toolCache.cacheFile;

exports.find2Impl = toolCache.findImpl;
exports.find2Impl = toolCache.find;
Copy link
Collaborator

@thomashoneyman thomashoneyman Sep 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@thomashoneyman
Copy link
Collaborator

thomashoneyman commented Sep 22, 2020

We'll need to update setup-purescript as well once this lands.

@thomashoneyman thomashoneyman merged commit 35ca19e into main Sep 22, 2020
@thomashoneyman thomashoneyman deleted the colin/set-up-test-action-and-fix-tool-cache-find branch September 22, 2020 17:36
@colinwahl colinwahl mentioned this pull request Oct 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees

@colinwahl colinwahl

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Calling ToolCache.find fails

3 participants

@colinwahl @thomashoneyman